Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove old swap & liquidity code #11181

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

refactor: Remove old swap & liquidity code #11181

wants to merge 9 commits into from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 8, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR primarily focuses on the removal of legacy code related to the V3Swap functionality and the restructuring of imports to streamline the Swap components, enhancing maintainability and clarity.

Detailed summary

  • Deleted multiple files related to V3Swap, including components, hooks, and types.
  • Updated SwapPage to render an empty fragment instead of the Swap component.
  • Changed import paths for hooks and utilities from V3Swap to a more centralized Swap directory.
  • Introduced new types and modified existing ones in types.ts.
  • Refactored several components and hooks to utilize updated import paths.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 946773f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 0:15am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
blog ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
games ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
gamification ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 0:15am
ton ⬜️ Skipped (Inspect) Feb 12, 2025 0:15am

memoyil
memoyil commented Feb 8, 2025
View reviewed changes
apps/web/src/views/Swap/V3Swap/components/index.ts
Copy link
Collaborator Author

@memoyil memoyil Feb 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

barrel exports prevents tree shaking

@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 09:44 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 09:45 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:40 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:01 Inactive
@memoyil memoyil changed the title refactor: Remove old swap code refactor: Remove old swap&liquidity code Feb 8, 2025
@memoyil memoyil changed the title refactor: Remove old swap&liquidity code refactor: Remove old swap & liquidity code Feb 8, 2025
@memoyil memoyil force-pushed the feature/refactor_remove_old_swap_code branch from 2f710e2 to e2170fa Compare February 8, 2025 15:04
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:31 Inactive
@memoyil memoyil force-pushed the feature/refactor_remove_old_swap_code branch from e123557 to 9f178fc Compare February 12, 2025 11:54
@vercel vercel bot temporarily deployed to Preview – ton February 12, 2025 11:54 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 12, 2025 12:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@memoyil